Garrett Rooney wrote:
> So I'm trying to review r16806, r16807 and r16842, so we can merge
> them into the 1.3 branch and do away with the mod_python
> multithreading crashes that have been reported. Part of the change
> makes sense (the atexit moving into python land instead of C land, so
> we can be sure it's still safe to run python code when our cleanups
> get called), but the rest seems to be a rewrite of the underlying
> python memory management stuff from C/Swig voodoo into python voodoo.
> Now as far as that goes, it looks fine, the python code seems to do
> something similar to what the C/Swig code did, at least to my
> untrained eye, but what's missing is an overview of what the stuff is
> generally trying to do.
>
> Does any such documentation exist? If not, could we perhaps write
> some, maybe placing a descriptive comment in proxy_apr.swg would be a
> good idea, just so the magic that occurs with the python bindings and
> APR pools can be more easily understood.
I agree. One thing in particular which I totally don't understand, and would
like to see explained, is why it is save for make_ob_pool() to totally
ignore its input.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 20:35:06 2005