[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]: Stop putting stuff in empty props files

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-10-20 19:08:28 CEST

On gcc checkouts, empty prop files with just the word END in them take
up roughly 250 meg of space.

I'm not joking.

This is simple to fix, however. We just need to start using hash_write2
with a NULL terminator in the wc code, to make them completely empty,
instead of using the old hash_read/hash_write.

However, this is not backwards compatible with hash_read.

I would really want to be able to get this into 1.3.x somehow, since
this is a very very big issue for gcc (it takes our working copy size
from 960 meg to 620, while cvs is 340).

I'm working on the auto-upgrade code to make this auto-upgrade okay (the
autoupgrade code just needs to walk all the props files once and rewrite
them), but i wanted some feedback about whether it's possible to get
into 1.3.x before i finish that.

[[[
Don't terminate empty props files with END

* subversion/libsvn_wc/props.c (svn_wc__load_prop_file): Use hash_read2
with no terminator.
(svn_wc__save_prop_file): Use hash_write2 with no terminator.
(svn_wc__wcprop_set): Ditto.
(svn_wc_prop_set_2): Ditto

]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Oct 20 19:09:22 2005

This is an archived mail posted to the Subversion Dev mailing list.