[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix broken svn_wc_dup_status2()

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-10-19 19:31:55 CEST


Was just trying to make good use of the new ood_* params in the
svn_wc_status2_t struct when I discovered a bug in svn_wc_dup_status2:
the ood_last_commit_author isn't copied! When I checked the source, I
also found that the url isn't copied either (which btw might explain
some crashreports I received for TSVN but never could really find the

So here's a patch to fix this.

I'd also recommend to backport this to 1.3.x (and if I'm not mistaken,
this also partly applies to 1.2.x - the url wasn't copied in those
versions either).


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

Fix broken svn_wc_dup_status2: copy the strings too.
* subversion/libsvn_wc/status.c
  (svn_wc_dup_status2): copy the url and the ood author too.
Index: subversion/libsvn_wc/status.c
--- subversion/libsvn_wc/status.c (Revision 16824)
+++ subversion/libsvn_wc/status.c (Arbeitskopie)
@@ -2086,6 +2086,12 @@
   if (orig_stat->repos_lock)
     new_stat->repos_lock = svn_lock_dup (orig_stat->repos_lock, pool);
+ if (orig_stat->url)
+ new_stat->url = apr_pstrdup (pool, orig_stat->url);
+ if (orig_stat->ood_last_cmt_author)
+ new_stat->ood_last_cmt_author = apr_pstrdup (pool, orig_stat->ood_last_cmt_author);
   /* Return the new hotness. */
   return new_stat;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 19 19:32:54 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.