On Tue, 18 Oct 2005, Philip Martin wrote:
> Daniel Rall <dlr@finemaltcoding.com> writes:
>
> >> Does your patch change the behaviour, i.e. it's now NULL for some
> >> other reason?
> >
> > No, the behavior should be identical; the field is initialized to NULL,
> > indicating that it is *not* out of date.
>
> > - /** Set to the user name of the youngest commit, or @c NULL if out
> > - * of date.
> > + /** Set to the user name of the youngest commit, or @c NULL if not
> > + * out of date.
> > * @since New in 1.3
> > */
> > const char *ood_last_cmt_author;
>
> That seems to imply that NULL is a reliable indication of the item not
> being out of date, but it may also happen if svn:author is missing and
> the item is out of date. I think ood_last_cmt_rev won't have this
> problem, callers should be using that to determine whether items are
> out of date.
Philip, you are right again -- r16798. Thanks for the great review.
- Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 18 23:16:56 2005