Re: r16754

Hi Peter,

Thanks for your detailed comments!

On 10/17/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > +svn_client_proplist_item_t *
> > +svn_client_proplist_item_dup (const svn_client_proplist_item_t *item,
> > + apr_pool_t * pool)
> > +{
> > + svn_client_proplist_item_t *new_item
> > + = apr_pcalloc (pool, sizeof (*new_item));
> > +
> > + if (item->node_name)
> > + new_item->node_name = svn_stringbuf_dup (item->node_name, pool);
> > +
> > + if (item->prop_hash)
> > + new_item->prop_hash = svn_string_hash_dup (item->prop_hash, pool);
> > +
> > + return new_item;
> > +}
> > +
>
> This doesn't belong in libsvn_subr.
Would libsvn_client/constructors.c be a reasonable location for the
svn_client_* methods and their helper functions?

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james