[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16735 - in trunk/subversion: libsvn_subr libsvn_wc

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-10-16 15:00:58 CEST

Kouhei Sutou <kou@cozmixng.org> writes:

> In <200510151724.j9FHO4J08094@morbius.ch.collab.net>
> "svn commit: r16735 - in trunk/subversion: libsvn_subr libsvn_wc" on Sat, 15 Oct 2005 12:24:04 -0500,
> djames@tigris.org wrote:
>> + apr_hash_this (hi, (const void *) &key, &klen, (void *) &val);
> Compiler says a warning. 'key' should be casted to 'const void **'.

Please use temporaries and avoid the casts altogether. Look at the
other uses of apr_hash_this in the code base.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 16 15:01:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.