[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16738 - trunk/subversion/libsvn_wc

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-10-16 14:55:08 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> On Sat, 2005-10-15 at 14:42 -0500, philip@tigris.org wrote:
>> + if (modify_flags & SVN_WC__ENTRY_MODIFY_SCHEDULE
>> + && entry->schedule == svn_wc_schedule_delete)
>
> It's wise to always use parentheses when mixing bitwise operators with
> other kinds of operators, because bitwise operators have an
> anti-intuitive precedence level for historical reasons.

Hmm, possibly. On the other hand I find it natural to write an
expression like that without extra parentheses, so adding them would
make it marginally less readable.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 16 14:55:50 2005

This is an archived mail posted to the Subversion Dev mailing list.