Re: [PATCH] Enable running autogen.sh with Python <2.1

Hi,

> > This patch enable running autogen.sh with Python <2.1 as well as >2.2.
> >
> > May I commit it?
> Looks great! Your code not only fixes the Python 2.1 problem but it
> also easier to read. +1. Please also nominate your fix for the 1.3.x
> branch.
>
> I have only a minor suggestion. Can you use "append(" instead of
> "append ("? (We try to avoid spaces before parentheses in Python
> code).
Thank you for your comment and approval.
I committed it as r16725 with that point fixed and also nominated as r16726.

# Actually, I read and write code written in Python for the first time
# to deal with this matter today. :-)

> > (or require building from autogen.sh with Python >2.2?)
> This might be a good idea. Does adding "from __future__ import
> nested_scopes" also resolve the problem with Python 2.1?
Yes, that addition can resolve for 2.1, but not for 2.0.

Since we describe in INSTALL that compiling require Python 2.0 or higher
(for Windows, 2.2 or newer), we must modify that description in case we
stop support for older Python...

- nori

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 15 10:00:31 2005