On 11 Oct 2005 21:46:02 -0500, kfogel@collab.net <kfogel@collab.net> wrote:
> kfogel@tigris.org writes:
> > Log:
> > * subversion/include/svn_opt.h
> > (svn_opt_revision_value_t): New name for svn_opt_revision_value.
> > (svn_opt_revision_t): Adjust accordingly.
>
> I believe this change obviates the need for some of r16649: now that
> this type has a "_t" suffix, the regexp changes of r16649 no longer
> need to allow for types that don't have "_t".
Great!
> However, a post-r16649 build/generator/swig/header_wrappers.py should
> still work just fine (it would accept a type without "_t", it just
> happens that it will never encounter such a type now), so I haven't
> made that tweak. If someone more knowledgeable in bindings matters
> could decide whether a partial reversion of r16649 is desirable,
> that'd be great.
header_wrappers.py looks for typedef'd structs and unions in our
public include files, and creates SWIG wrappers for them. There's no
disadvantage to accepting typedefs which don't end in "_t", so I'll
leave header_wrappers.py alone for now.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Received on Wed Oct 12 22:44:59 2005