[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16652 - trunk/subversion/include

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-11 22:40:43 CEST

On Tue, 11 Oct 2005, kfogel@collab.net wrote:
> Why is it not 'svn_opt_revision_value_t'? I thought we always used _t
> for types that are unaccompanied by some other type-indicating keyword
> (e.g., 'struct' or 'enum'). We should settle this now, since this is
> going into 1.3.

I too prefer the _t suffix, which is consistent with our struct naming
convention. While we're at it, why bother naming the enum when it's just
going to be typedef'd (e.g. does SWIG need that)? Leaving it anonymous
results in less code to read. My $0.02 USD.

- Dan

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 11 22:40:02 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.