[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Note latent bug in libsvn_wc/diff.c

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-07 23:30:49 CEST

I've just spotted what I'm almost certain is a bug in libsvn_wc/diff.c,
and I'd like to make sure it's not forgotten.

So why not add a regression test? The precise bug is that svn_client_diff3()
will, for wc->repos diffs, report deleted directories as adds. However,
BASE<->repos diffs don't currently report deleted directories at all
(that's another bug), and there's no way to get the command-line client
to request a WORKING->repos diff, only a repos->WORKING diff (which in
this situation, produces identical - but this time, correct - output).

It should be possible to reproduce this by calling svn_client_diff3()
directly, of course, but I don't have the time (or experience) to be
able to create a regression test that doesn't just drive the command-line
client, so this seemed like the next-best thing.

* subversion/libsvn_wc/diff.c
  (delete_entry): Add a comment noting that we don't correctly handle
    deleted directories for wc->repos diffs at present.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Oct 7 23:31:48 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.