[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Improve two comments in libsvn_client/diff.c

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-07 03:04:24 CEST

In both diff_repos_repos() and, now, diff_summarize_repos_repos(), we
open two RA sessions: the first for the main request, and the second as an
auxillary so that we can make additional requests during the main request.

The existing comment reads:
  /* Now, we reopen two RA session to the correct anchor/target
     locations for our URLs. */

I think this is far too easy to mis-interpret: it suggests that we're
opening one RA session to the first URL's anchor, and another RA session
to the second URL's anchor. If you do notice the fact that both of the
following calls use anchor1, it just looks like it might be a typo.

(The comments were changed in r6557, if anyone's interested).

[[[
* subversion/libsvn_client/diff.c
  (diff_repos_repos, diff_summarize_repos_repos): Change comments to
    clarify which anchors the two RA sessions are opened for.
]]]

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Oct 7 03:05:17 2005

This is an archived mail posted to the Subversion Dev mailing list.