Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'

"Madan US" <madan@collab.net> writes:

> Index: subversion/tests/clients/cmdline/basic_tests.py
> ===================================================================
> --- subversion/tests/clients/cmdline/basic_tests.py (revision 16440)
> +++ subversion/tests/clients/cmdline/basic_tests.py (working copy)
> @@ -1610,7 +1610,13 @@
> output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> 'cat', url+'@')
>
> + # With the trailing "/", expect success.
> + output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> + 'cat', wc_file+'/')
> + output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> + 'cat', url+'/')
>
> +
> #----------------------------------------------------------------------
> ########################################################################
>
> Issue #2318: Inconsistent behavior with trailing '/'
>
> * subversion/libsvn_subr/path.c
> (svn_path_canonicalize): Modified to replace the trailing slash
> in the filename to @ if the last segment of the file path
> contained an @.
> * subversion/test/clients/cmdline/basic_tests.py
> (basic_peg_revision): Modified to check for the @ sign and the
> trailing slash combination.

Your test doesn't really check your new code since it doesn't use an
'@' sign. You should probably write more complete tests, i.e. all
combinations, in test_canonical in tests/libsvn_subr/path-test.c.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org