[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_fs_* make use of functions declared in _private_ libsvn_delta header

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-10-04 19:16:43 CEST

On Tue, 2005-10-04 at 18:10 +0100, Max Bowsher wrote:
> The two fs backend implementations both use the functions
> svn_txdelta__apply_instructions() and svn_txdelta__compose_windows(), which
> are declared in subversion/libsvn_delta/delta.h.
> If those functions are to be used cross-library, should they not become part
> of the public API?

As a matter of general principle, no. I think we need the ability to
have cross-library private functions.

But in this specific instance, yes, I see no reason why we should have
private libsvn_delta functionality exposed to libsvn_fs. At least
svn_txdelta__compose_windows is from brane; I don't know why he chose to
make that private.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 19:18:08 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.