[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python bindings svn_wc_entry() is broken

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-04 18:47:15 CEST

David James wrote:
> On 10/4/05, Max Bowsher <maxb@ukf.net> wrote:
>>>>> svn.wc.entry('nonexistentpath', aa, False)
>> <libsvn.core.GenericSWIGWrapper instance at 0x5d820c>
>> The problem is with functions that deliberately return a NULL pointer to
>> signify "does not exist".
>> The correct Python translation of this would be None, but the bindings
>> are
>> incorrectly returning an internal wrapper object. This is bad, because
>> any
>> code making any real use of svn_wc_entry will be testing the return value
>> either for truth or None-ness in order to tell whether the entry was
>> found,
>> and this will break that.

> Good catch, Max! This should be fixed in r16450.

Thanks for the quick fix.
I've committed a small followup in r16454 and nominated both for backport.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 18:48:01 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.