[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] V3, diff summarize (preview) without text deltas

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-10-03 15:30:57 CEST

On Sun, 2 Oct 2005, Martin Hauner wrote:

> attached is the third version of the diff summarize api call that doesn't
> produce text deltas (which helps to build a nice diff interface in a gui
> client or at least that's why i did write it :) This is also partially
> issue #2015 (without -v).
>
> I have fixed/updated it based on Peter Lundblads nice review and cleaned
> up a few other things.
>
Thanks for those kind words:-) Just FYI, I'm in the process of applying
this patch, since it looks very good overall. There are small style nits
here and there, which I'm fixing as I go through the patch. I'm doing one
larger change, though. INstead of one kind field and two boolean fields in
svn_client_diff_summarize_t, I'm combining item and text "status" into one
filed as we do in the status APIs. I think that's more intuitive. Also,
I'm getting rid of the _unchanged kind, which is only used internally and
therefore shouldn't be exposed.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 3 15:34:39 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.