[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16387 - trunk/subversion/libsvn_ra_svn

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-02 14:31:54 CEST

Greg Hudson wrote:
> On Sat, 2005-10-01 at 12:09 -0500, maxb@tigris.org wrote:
>> * subversion/libsvn_ra_svn/client.c (find_tunnel_agent): URI-decode
>> hostinfo portion of URL before using it to construct tunnel agent
>> argv.
>
> apr_uri_parse() doesn't do this for us? It seemed intuitive to me that
> it would.

Nope, I tested by defining a fake tunnel agent which just printed its
arguments to stderr.

> (And perhaps fundamentally broken that it doesn't.)

I agree, it is more intuitive to assume that 'parsing' an URI would include
URI-decoding.

> It'd be nice if APR would document these things.

Yes.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 2 14:33:26 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.