[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Set wc admin dir name in bindings [Was: Fix position of apr_initialize() in Python bindings]

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-01 14:22:15 CEST

Branko Čibej wrote:
> Max Bowsher wrote:
>> Branko Čibej wrote:
>>> Max's patch gave me an idea for implementing the svn_wc_set_adm_dir hack
>>> for all bindings libs. Can someone please review this and tell me if I'm
>>> completely insane?
>> Unfortunately, if someone does just "import svn.wc", then the wc
>> initfunc runs *before* the core initfunc, so apr is not initialized at
>> this time.
> Yes, I figured as much after I posted this patch. Ah, well. It would be
> really nice if we could do something like this for the bindings...

This takes care of it for Python, I think:

Index: subversion/bindings/swig/svn_wc.i
--- subversion/bindings/swig/svn_wc.i (revision 16385)
+++ subversion/bindings/swig/svn_wc.i (working copy)
@@ -296,3 +296,20 @@

 %include svn_wc_h.swg
+%inline %{
+svn_error_t *
+svn_swig_init_asp_dot_net_hack (apr_pool_t *pool)
+#ifdef WIN32
+ if (getenv ("SVN_ASP_DOT_NET_HACK"))
+ SVN_ERR (svn_wc_set_adm_dir("_svn", pool));
+#endif /* WIN32 */
+ return SVN_NO_ERROR;
+#if defined(SWIGPYTHON)
+%pythoncode %{ svn_swig_init_asp_dot_net_hack() %}

The other languages will need to invoke svn_swig_init_asp_dot_net_hack()
from their handcoded layers:
* subversion/bindings/swig/perl/native/Wc.pm
* subversion/bindings/swig/ruby/svn/wc.rb

I haven't done that, because I don't know ruby, and the perl file is quite
large, so I would rather let a perl bindings person put it in the section
that makes most sense to them.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 1 14:23:19 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.