Philip Martin <philip@codematters.co.uk> writes:
> > On Thu, 29 Sep 2005, Philip Martin wrote:
> > ...
> >> SVN_NEON_0_25 is an AC_SUBST value in svn_private_config.h and it's
> >> either a #define to 1 or it's completely absent. Looking through the
> >> code we test for it using #if, should we be using #ifdef instead? I
> >> know it makes little difference at the moment, but we do use #ifdef
> >> for things like SVN_HAVE_OLD_EXPAT and SVN_LIBSVN_FS_LINKS_FS_BASE.
> >
> > #ifdef
>
> I see that this was discussed before and that Karl expressed a
> preference for #if
>
> http://svn.haxx.se/dev/archive-2005-06/0511.shtml
Thanks for digging that up, Philip.
I'm +1 on changing the opposite tests to "#if ! PREPROCESSOR_CONSTANT"
instead of "#ifndef PREPROCESSOR_CONSTANT" wherever applicable, of course.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 1 03:33:51 2005