[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: How do the Python bindings call apr_initialize() ?

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-09-30 18:45:41 CEST

David James wrote:
> On 9/30/05, Max Bowsher <maxb@ukf.net> wrote:
>> David James wrote:
>>> Does the attached patch fix the problem?
>>>
>>> [[[
>>> * swig/proxy/proxy_apr.swg: Call apr_initialize() at import time.
>>> ]]]
>>
>> Yes, it does, thanks.

> Great! But I'm not sure this is the right solution. See below.
>
>> I'm very confused as to why this affected Cygwin but not Linux.

> If ACQUIRE_PYTHON_LOCK is defined, we call apr_initialize during
> svn_swig_py_release_py_lock in
> swig/python/libsvn_swig_py/swigutil_py.c.
> (This means that we initialize APR multiple times on Linux.)
>
> Perhaps we should remove the apr_initialize and apr_terminate calls
> from proxy_apr.swg, and instead patch swigutil_py.c to initialize and
> terminate APR on all platforms? (How do you suggest we do this?)

Thanks for the clarification!

I suggest we call apr_initialize() from initialization function of
libsvn._core - the same place we register the SubversionException type.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 30 18:46:43 2005

This is an archived mail posted to the Subversion Dev mailing list.