[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_repos_create should allow fs_config being null

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-09-30 10:46:39 CEST

> On Fri, 30 Sep 2005, Chia-liang Kao wrote:
> ...
>> Log:
>> Fix check-swig-pl failures.
>> * libsvn_repos/repos.c:
>> (svn_repos_create) Allow fs_config to be null, as svn_repos.h says so.

Sorry for not noticing that! Thanks for cleaning up after me, clkao.

Daniel L. Rall wrote:
> That would leave repos->fs_type uninitialized if fs_config was NULL. How
> about this?

No, clkao's original patch was correct.

What's currently committed has the flaw that when opening a non-default
fs-type, repos->fs_type holds a meaningful but incorrect value for a while,
instead of holding NULL (i.e. unknown) until the real data is known.
I'll revert what was committed, commit clkao's patch instead, and propose
for backport.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 30 10:52:04 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.