[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #1911 -- Seeking thinker donations

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-29 20:02:13 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> On Thu, 2005-09-29 at 11:28 -0400, C. Michael Pilato wrote:
> > My change to svndumpfilter was to make it say, "If the copyfrom source
> > revision is one which I've dropped, then use the youngest not-dropped
> > revision which is older than that dropped revision." (And again, I
> > implemented this twice: once brute-force, once with some class.)
> >
> > Here's where I'm getting hung up, though. I've not fully convinced
> > myself that this is a safe algorithm to fallback to.
> I think it should be safe. If the copy source was not filtered out,
> then there should be no dropped revisions which affect the copy source,
> which means copysource@original-copy-rev and
> copysource@next-older-copy-rev should be the same node-revision.

That was my thinking too.

And in the one exception case, where the copy source *is* filtered but
the copy is converted to an add-without-history, the copyfrom-rev is
dropped altogether.

I'm going to commit that second patch up. Thanks for the sanity
check, Greg.

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 29 22:19:15 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.