[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add "copied" subcommand to svnlook

From: Paul Dugas <paul_at_dugas.cc>
Date: 2005-09-28 20:01:24 CEST

On Tue, September 27, 2005 5:45 pm, Peter N. Lundblad wrote:
> Heh, the full committers (including me). We only have show- in one other
> option, I think it is redundant, so lets settle on --copy-info unless
> someone objects.

Done.

> As above:-) I didn't find that suggestion for no slash at the beginning.
> I don't think it should be remvoed, for consistency.

Done.

>>> Else, it looks good. Would you mind creating a basic test case for
>>> this in svnlook_tests.py?
>>
>> Um... Never been a Python programmer and at first glance at that
>> script, I remember why. ;) I'll take another look and see what I can
>> swing.
>>
> Looking forward to that. It is not hard, but a basic test case for the
> format is a good starter.

Will look at that again tonight.

> Good summary!

Tweaked it a bit more but thanks! I'm much more of a coder that a writer.
 I can touch-type C, Perl, etc. but not English. Wierd. Anytime I get a
compliment in that area, I have to enjoy it while it lasts. Thanks again.

> I liked your previous way of doing this better, just with an extended
> status char array to make room for the new column and a boolean flag. It
> was more straight-forward and less code duplication.

Agreed.

Attached is the latest.

Thanks,

Paul

-- 
Paul Dugas, Computer Engineer           Dugas Enterprises, LLC
paul@dugas.cc     phone: 404-932-1355   522 Black Canyon Park
http://dugas.cc     fax: 866-751-6494   Canton, GA 30114 USA
--
Onsite at GDOT W.Annex 404-463-2860 x199


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Sep 28 20:02:31 2005

This is an archived mail posted to the Subversion Dev mailing list.