[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pre-revprop-change hook problems

From: Michael Sinz <Michael.Sinz_at_sinz.org>
Date: 2005-09-28 17:01:15 CEST

Ben Collins-Sussman wrote:
> That's probably because the user is performing the action anonymously.
> It means you've misconfigured your server -- it should be sending an
> authentication challenge, and it isn't.
>
> Granted, if no user is available, perhaps we should call the hook with
> "anonymous" as the 3rd argument, or something...? That would be
> inconsistent with other existing policies, though. For example, if
> somebody performs an anonymous commit, we don't attach a revision
> property of 'svn:author = anonymous' -- the svn:author property just
> doesn't exist on the revision.

Maybe it should just be "" as the 3rd argument. Leaving out the argument
makes for major problems with positional argument stuctures. However,
making the argument the empty string ("") would still flow correctly
and fix the issue and not introduce some special user name.

> On 9/28/05, Norbert Unterberg <nunterberg@gmail.com> wrote:
>
>>I need to warm this issue up:
>>
>>The pre-revprop-hook does not work as advertised, at least not for
>>Subversion 1.2.3 running on apache on windows:
>>
>>The template says:
>>
>># [1] REPOS-PATH (the path to this repository)
>># [2] REVISION (the revision being tweaked)
>># [3] USER (the username of the person tweaking the property)
>># [4] PROPNAME (the property being set on the revision)
>># [5] ACTION (the property is being 'A'dded, 'M'odified, or 'D'eleted)
>>
>>But when the hook is called, the argument 3 (the user name) is
>>missing, so propname is %3 and action is %4. This broke our existing
>>hooks after the upgrade from SVN 1.1 to 1.2.
>>
>>The other problem is that the error message sent to stdout (echo
>>Property "%PROPNAME%" cannot be changed >&2) is no longer transmitted
>>back to the client.
>>
>>Norbert
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>>For additional commands, e-mail: dev-help@subversion.tigris.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>

-- 
Michael Sinz                     Technology and Engineering Director/Consultant
"Starting Startups"                                mailto:michael.sinz@sinz.org
My place on the web                            http://www.sinz.org/Michael.Sinz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 28 17:02:51 2005

This is an archived mail posted to the Subversion Dev mailing list.