[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: rfc on structure changes

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-09-28 11:32:21 CEST

On Thu, 2005-09-22 at 00:17, Peter N. Lundblad wrote:
> On Wed, 21 Sep 2005, Madan U Sreenivasan wrote:
> > This is a request for modifying the way certain publicly available
> > structures are written. The below is the only example am able to give...
> > but its possible that there are more like this...
> >
> > svn_ra_plugin_t structure in subversion/include/svn_ra.h. I need to
> > change a parameter of the svn_commit_callback_t member.
> You don't need to change anything in that struct:-) It is deprecated and
> not used anymore except for backwards compatibility. The internal
> svn_ra__vtable_t can be changed at will.
  I'm stuck trying to change svn_ra__vtable_t (at will ;) ). Here, am
having to change the signature of the get_commit_editor member to use

  Now, svn_ra_get_commit_editor() will have to be deprecated, and will
force us to retain usage of svn_commit_callback_t. Now this will force
us to retain all callbacks(even private) and functions that use them,
till the repos layer and for all three ra libraries.
  What more, svn_commit_callback_t uses individual commit info values
instead of the comprehensive svn_commit_info_t structure. This means, we
need to retain all private functions with individual commit information
parameters, instead of changing to the more efficient svn_commit_info_t
structure. :/

  Am I missing something here? Is there a easy way to do this, other
than retaining all private functions that use svn_commit_callback_t and
individual commit information vars instead of svn_commit_info_t?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 28 11:24:38 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.