[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16304 - trunk/subversion/bindings/swig/python/tests/trac/versioncontrol/tests

From: David James <james82_at_gmail.com>
Date: 2005-09-27 20:45:39 CEST

On 9/27/05, Branko ╚ibej <brane@xbc.nu> wrote:
> djames@tigris.org wrote:
>
> >+ # Remove the trac-svnrepos directory, so that we can
> >+ # ensure a fresh start.
> >+ try:
> >+ self.tearDown()
> >+ except:
> >+ pass
> >
> >
> Why the last two lines? If the test repository can't be removed, it's a
> safe bet that the tests won't work anyway.
If the test repository doesn't exist, then self.tearDown() throws an
exception. We catch this exception, so that the test scripts will work
if the trac-svnrepos directory has not been created yet.

(Perhaps it would be better to fix self.tearDown to check whether the
repository actually exists, before trying to delete it.)

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
Received on Tue Sep 27 20:46:41 2005

This is an archived mail posted to the Subversion Dev mailing list.