[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] size and force text files to be considered binary in mailer.py

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-09-26 21:40:00 CEST

Michael W Thelen wrote:

>Jon Bendtsen wrote:
>
>
>>The mailsize is calculated by having a hardcoded max size limit in the
>>mailer.py script.
>>For every diff
>> for every line
>> i take the length of the line and subtract it from the max size.
>> If the max size reaches 0 or below, one more line is added
>> saying that the limit has been reached and no more text is
>> included in the email.
>>
>>Currently the limit is hardcoded to 2MB
>>
>>Further more the number of diffs are counted and if there is more than
>>128 diffs/files, it aborts
>>futher generation as well, but does send the mail that was genereated
>>so far.
>>
>>
>
>I don't know Python, so I can't comment much on the patch itself, but it
>does seem like the max mail size and max diffs could be specified as
>parameters instead of hard-coded.
>
>
Yes, mailer.py already has a config file, so adding those parameters
seems logical.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 26 21:41:53 2005

This is an archived mail posted to the Subversion Dev mailing list.