Re: svn commit: r16244 - in trunk: . subversion/clients/cmdline subversion/include subversion/libsvn_client subversion/libsvn_wc subversion/svnversion subversion/tests/clients/cmdline subversion/tests/clients/cmdline/svntest tools/examples

On Mon, Sep 26, 2005 at 03:04:10PM +0200, Branko Čibej wrote:
> So, any suggestions? We could do away with the atomics completely _if_
> we require single-threaded initialisation.

From the comments added to svn_wc.h in r16270, I got the impression
that we _were_ requiring single-threaded initialisation:

 * @note This function changes global (per-process) state and should,
 * to maintain consistency, be called in a single-threaded context
 * during the initialization of a Subversion client.

(Obviously, that wasn't the intention, since you kept the atomic code.
I'm just pointing out that I'd personally interpret that comment to
mean that I shouldn't call svn_wc_set_adm_dir() from multiple threads -
even if I were setting the same value).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 26 15:36:04 2005