[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16244 - in trunk: . subversion/clients/cmdline subversion/include subversion/libsvn_client subversion/libsvn_wc subversion/svnversion subversion/tests/clients/cmdline subversion/tests/clients/cmdline/svntest tools/examples

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-09-25 20:23:31 CEST

Max Bowsher wrote:

>> Author: brane
>> Date: Sat Sep 24 21:22:00 2005
>> New Revision: 16244
>
> ...
>
>> Log:
>
> ...
>
>> - On Windows, setting the environment variable SVN_ASP_DOT_NET_HACK
>> will change the admin dir name to "_svn".
>
> ...
>
>> * subversion/clients/cmdline/main.c,
>> subversion/svnversion/main.c,
>> tools/examples/minimal_client.c: On Windows, if the environment
>> variable
>> SVN_ASP_DOT_NET_HACK is set, change the admin dir name to "_svn".
>
> ...
>
>> +#ifdef WIN32
>> + /* Set the working copy administrative directory name. */
>> + if (getenv ("SVN_ASP_DOT_NET_HACK"))
>> + {
>> + err = svn_wc_set_adm_dir ("_svn", pool);
>> + if (err)
>> + return svn_cmdline_handle_exit_error (err, pool, "svn: ");
>> + }
>> +#endif
>
>
>
> Why restrict this to Windows?
> Suppose some asp.net user ends up with a broken wc, zips it up and
> gives it to their unix sysadmin for troubleshooting?
> Corner case, I know, but with such a distinctive env-var name, is
> there any harm in letting this code remain available on all platforms,
> just in case?

This is a workaround for a specific bug in ASP.NET. We've been fighting
for ages against putting this into the mainline, but decided to finally
do it in the interests of reducing the need for private forks.

However, we want to reduce the spread of this WC-incompatibility plague
as much as possible. We already know it's a temporary measure because
AFAIK the newest version of ASP.NET no longer has this bug.

Your unix sysadmin, unlike your typical Windows user, has the pleasure
of having sensible tools available, so she can say

    for d in `find . -type d -name _svn`; do
      mv $d `dirname $d`/.svn
    done

> And, if it is to be restricted to Windows, what about 64-bit Windows?
> (#ifdef WIN32)

All our Windows-specific code is wrapped like this. Nobody, as far as I
know, has ever compiled Subversion on Win64. Starting the port blindly
in this particluar case makes no sense, it's better to do it all at once.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 25 20:26:56 2005

This is an archived mail posted to the Subversion Dev mailing list.