[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Keywords as hash: API design: null or empty hash

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-09-22 15:17:48 CEST

Julian Foad wrote:
> That said, I tentatively suggest the attached patch. What do you think
> of it?

I think that looks good. I'm still not entirely convinced it wouldn't
be better to always set NULL in svn_subst_build_keywords2(), but I can
see your argument against that change on a code consistency basis alone.

> Thanks. Again, it's not critical because the real meaning can be
> inferred - the text is not significantly misleading. If you'd rather
> leave it to me, that's fine, I'm happy to do it.

If you wouldn't mind...


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 15:18:24 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.