[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Keywords as hash: API design: null or empty hash

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-09-22 04:29:16 CEST

Julian Foad wrote:
> Check whether the implementations of the functions that accept a
> keywords hash are reasonably efficient both when given NULL and when
> given an empty hash.
> svn_subst_keywords_differ2(a,b) - yes
> svn_subst_translate_stream3(keywords) - no
> svn_subst_copy_and_translate3(keywords) - no
> svn_subst_translate_cstring2(keywords) - no

Is this something we need to get into 1.3? I would think not, since we are only
changing efficiency not functionality, at this point, so it can easily go into
1.3.1. I don't think I'll be able to put off actually working on legitimate
work stuff any longer, so if it has to get fixed for 1.3, I'm probably not going
to be the one to do it.

> Clean up svn_subst_translate_stream3()'s doc string: it refers to
> keywords in the hash having null values, and to the syntax
> "keywords->revision".

That's easier to get done; if someone else doesn't beat me to it, I'll submit a
patch tomorrow.


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 04:29:41 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.