[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16162 - in trunk/subversion: include libsvn_fs libsvn_fs_fs

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-21 14:57:10 CEST

Daniel Rall <dlr@finemaltcoding.com> writes:

> > Would you be +1 on getting rid of the enum type and just returning a
> > constant string (i.e., allocated in static data segment, not pool)
> > from svn_fs_type()? I'm happy to make the change...
>
> As you say, there are trade-offs, but I think your suggestion of strings
> instead of an enum would be preferable, as it doesn't lend the (false)
> appearance that all possible FS backend types are known.

+1.

(And nice catch, Dan.)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 21 14:58:53 2005

This is an archived mail posted to the Subversion Dev mailing list.