Philip Martin <philip@codematters.co.uk> writes:
> kfogel@collab.net writes:
> > sussman@tigris.org writes:
> >> --- trunk/subversion/mod_dav_svn/deadprops.c (original)
> >> +++ trunk/subversion/mod_dav_svn/deadprops.c Fri Sep 16 19:14:03 2005
> >> @@ -168,7 +168,8 @@
> >> /* Tell the logging subsystem about the revprop change. */
> >> apr_table_set(db->resource->info->r->subprocess_env, "SVN-ACTION",
> >> apr_psprintf(db->resource->pool,
> >> - "changed value of revision property '%s'",
> >> + "revprop-change r%" SVN_REVNUM_T_FMT
> >> + " '%s'", db->resource->info->root.rev,
> >> propname));
> >> }
> >
> > We don't use SVN_REVNUM_T_FMT anymore (see its doc string, it's now
> > obsolete). Just use "%ld".
>
> We don't use SVN_REVNUM_T_FMT because of i18n problems, but those
> concerns don't apply to the code above so it's use might be
> acceptable.
Yes, but if we start letting back into parts of our code, those parts
will inevitably be used as examples (or even as cut-and-paste sources)
by programmers working in other areas of Subversion. I think the best
policy is simply to do what the current doc string of SVN_REVNUM_T_FMT
says, and not use it in Subversion.
-Karl
--
www.collab.net <> CollabNet | Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 21 00:03:10 2005