[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16151 - trunk/subversion/mod_dav_svn

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-09-20 23:47:27 CEST

On Tue, 20 Sep 2005, Philip Martin wrote:

> kfogel@collab.net writes:
>
> > sussman@tigris.org writes:
> >> --- trunk/subversion/mod_dav_svn/deadprops.c (original)
> >> +++ trunk/subversion/mod_dav_svn/deadprops.c Fri Sep 16 19:14:03 2005
> >> @@ -168,7 +168,8 @@
> >> /* Tell the logging subsystem about the revprop change. */
> >> apr_table_set(db->resource->info->r->subprocess_env, "SVN-ACTION",
> >> apr_psprintf(db->resource->pool,
> >> - "changed value of revision property '%s'",
> >> + "revprop-change r%" SVN_REVNUM_T_FMT
> >> + " '%s'", db->resource->info->root.rev,
> >> propname));
> >> }
> >
> > We don't use SVN_REVNUM_T_FMT anymore (see its doc string, it's now
> > obsolete). Just use "%ld".
>
> We don't use SVN_REVNUM_T_FMT because of i18n problems, but those
> concerns don't apply to the code above so it's use might be
> acceptable.
>
Acceptable in the sense that it works, but unnecessary and confusing since
we can't reasonably change that constant anyway. So I think it should go.

REgards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 23:48:47 2005

This is an archived mail posted to the Subversion Dev mailing list.