[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16172 - trunk/subversion/libsvn_subr

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-20 22:25:48 CEST

dlr@tigris.org writes:

> Author: dlr
> Date: Tue Sep 20 15:09:17 2005
> New Revision: 16172
>
> Modified:
> trunk/subversion/libsvn_subr/subst.c
>
> Log:
> * subversion/libsvn_subr/subst.c
> (svn_subst_keywords_differ2): Collapse a redundant conditional block
> into a single "if" statement.
>
> Modified: trunk/subversion/libsvn_subr/subst.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/subst.c?rev=16172&p1=trunk/subversion/libsvn_subr/subst.c&p2=trunk/subversion/libsvn_subr/subst.c&r1=16171&r2=16172
> ==============================================================================
> --- trunk/subversion/libsvn_subr/subst.c (original)
> +++ trunk/subversion/libsvn_subr/subst.c Tue Sep 20 15:09:17 2005
> @@ -735,11 +735,8 @@
> a_count = (a == NULL) ? 0 : apr_hash_count (a);
> b_count = (b == NULL) ? 0 : apr_hash_count (b);
>
> - if (a_count != b_count)
> + if (a_count != b_count || a_count == 0)
> return TRUE;
> -
> - if (a_count == 0)
> - return FALSE;

Now, I may be just reading that wrongly, but have you not just changed
the logic here? a_count == 0 used to return FALSE, now it returns
TRUE.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 22:32:40 2005

This is an archived mail posted to the Subversion Dev mailing list.