[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Was: Enhancement needed in svn status -u

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-09-20 14:53:43 CEST

Could someone possibly find the time to review this patch? We really need
this in Subclipse and I would hate to see it not make the cut for 1.3. It
is a completely internal change as far as the CLI goes, but it makes some
information available that we need in Subclipse from JavaHL. The
referenced thread contains more detail.

I think I am partially responsible for this not getting a review as I put
forth some ideas as to other more radical ways this change could be made.
I think the conclusion from those discussions was that the approach that
Paul gave below is probably the best.

Thanks

Paul Burba/SoftLanding Systems wrote on 08/22/2005 06:08:56 PM:

> In response to this thread:
> http://svn.haxx.se/dev/archive-2005-08/0257.shtml, here is my first
> attempt at a patch to provide more detailed out of date information in
> svn_wc_status2_t when using the -u option with svn status.
>
> If anyone has some time to take a look at this I'd appreciate it.
>
> One known problem with the patch: It doesn't pick up the last committed
> author and date for a WC item that has been deleted in the repository.
If
> anyone has suggestions on this front I'd love to hear them.
>
> Thanks,
>
> Paul B.
>
> [[[
> Provide more complete server-side information about out of date items
when
> using svn status with -u option.
>
> * subversion/include/svn_wc.h
> (svn_wc_status2_t): Add new fields to store the most recent revision,
> author,
> and commit date for an out of date item, as well as its url and node
> type.
>
> * subversion/libsvn_repos/reporter.c
> (delta_dirs): Pass s_rev to b->editor->delete_entry so it has the last
> committed rev of the deleted item.
>
> * subversion/libsvn_wc/status.c
> include svn_time.h
> (dir_baton, file_baton): Add new fields mirroring those in
> svn_wc_status2_t.
> (assemble_status): Initialize new svn_wc_status2_t members.
> (make_dir_baton): Initialize new dir_baton members.
> (make_file_baton): Initialize new file_baton members.
> (copy_ood_info): New helper function.
> (delete_entry): Store readily available out of date info in
appropriate
> svn_wc_status2_t structure in db->statii.
> (change_dir_prop, change_file_prop): Temporarily store out of date
info
> in
> dir_baton or file_baton respectively.
> (close_directory, close_file): If item is out of date, copy ood info
> from
> dir_baton or file_baton respectively to the appropriate
> svn_wc_status2_t
> structure in dir/file_baton->parent_baton->statii.
> ]]]
>
>
> [attachment "status-u-v.diff" deleted by Mark Phippard/SoftLanding
Systems]

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 14:55:16 2005

This is an archived mail posted to the Subversion Dev mailing list.