[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16151 - trunk/subversion/mod_dav_svn

From: <kfogel_at_collab.net>
Date: 2005-09-20 03:19:55 CEST

sussman@tigris.org writes:
> --- trunk/subversion/mod_dav_svn/deadprops.c (original)
> +++ trunk/subversion/mod_dav_svn/deadprops.c Fri Sep 16 19:14:03 2005
> @@ -168,7 +168,8 @@
> /* Tell the logging subsystem about the revprop change. */
> apr_table_set(db->resource->info->r->subprocess_env, "SVN-ACTION",
> apr_psprintf(db->resource->pool,
> - "changed value of revision property '%s'",
> + "revprop-change r%" SVN_REVNUM_T_FMT
> + " '%s'", db->resource->info->root.rev,
> propname));
> }

We don't use SVN_REVNUM_T_FMT anymore (see its doc string, it's now
obsolete). Just use "%ld".

> --- trunk/subversion/mod_dav_svn/update.c (original)
> +++ trunk/subversion/mod_dav_svn/update.c Fri Sep 16 19:14:03 2005
> @@ -1385,11 +1385,11 @@
> /* diff/merge don't ask for inline text-deltas. */
> if (uc.send_all)
> action = apr_psprintf(resource->pool,
> - "switch from '%s' to '%s'",
> + "switch '%s' '%s'",
> spath, dst_path);
> else
> action = apr_psprintf(resource->pool,
> - "diff or merge, comparing '%s' and '%s'",
> + "diff-or-merge '%s' '%s'",
> spath, dst_path);

Here and in many places in Subversion, we need a function that will
quote the single quotes in a path, so that our convention of enclosing
paths in single quotes is truly parseable. It's especially noticeable
here because there's one path followed immediately by another, but
it's really a global issue.

About encoding:

These logs are written on the server side. The paths are all in
UTF-8. Should we be doing something to determine the server's own
encoding and writing out the paths in that encoding? Or does recoding
take place when the entire log line is written out?

> --- trunk/subversion/mod_dav_svn/version.c (original)
> +++ trunk/subversion/mod_dav_svn/version.c Fri Sep 16 19:14:03 2005
> @@ -1703,7 +1703,7 @@
> /* We've detected a 'high level' svn action to log. */
> apr_table_set(target->info->r->subprocess_env, "SVN-ACTION",
> apr_psprintf(target->info->r->pool,
> - "committed r%" SVN_REVNUM_T_FMT, new_rev));
> + "commit r%" SVN_REVNUM_T_FMT, new_rev));

Same thing about SVN_REVNUM_T_FMT.

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 04:25:57 2005

This is an archived mail posted to the Subversion Dev mailing list.