[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16097 - in trunk/subversion: bindings/swig/perl/native include libsvn_fs libsvn_fs_base libsvn_repos tests/clients/cmdline tests/libsvn_fs

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-18 04:17:56 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:

> kfogel@collab.net writes:
> > Ben Collins-Sussman and Chia-Liang Kao tracked this down today. I'm a
> > little too tired to fix it now, but wanted y'all to know that it has
> > been spotted and I will fix it (unless Mike wakes up before me and
> > fixes it first). Note that he and I wrote that commit together, so
> > don't blame Mike just because the revision says 'cmpilato' on it.
> Actually, that's ghudson's part of the change, but we absolutely get
> spanked for not reviewing it before committing. Sorry, dev-folk. :-(
> I'll try to fix this now.

So, I just realized that to fix this I'd have to setup mod_authz_svn
or somesuch (which I'm not really primed to do right now). Is there
anybody out there with such a setup that could test this patch:

Index: subversion/libsvn_repos/rev_hunt.c
--- subversion/libsvn_repos/rev_hunt.c (revision 16153)
+++ subversion/libsvn_repos/rev_hunt.c (working copy)
@@ -446,8 +446,11 @@
   revision = is_ancestor ? *revision_ptr : peg_revision;
   path = fs_path;
   if (authz_read_func)
- SVN_ERR (check_readability (root, fs_path, authz_read_func,
- authz_read_baton, pool));
+ {
+ SVN_ERR (svn_fs_revision_root (&root, fs, revision, pool));
+ SVN_ERR (check_readability (root, fs_path, authz_read_func,
+ authz_read_baton, pool));
+ }
   while (revision_ptr < revision_ptr_end)

It's ever-so-mildly inefficient in that we'll be fetching a root for
one particular revision twice over the course of the run, but the
alternative made for nastier code, and I don't think we'll actually
ever see degrading performance as a result of this concession.

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 18 04:19:01 2005

This is an archived mail posted to the Subversion Dev mailing list.