[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r12365: URL canonicalisation bug in "checkout"

From: Josh Pieper <jjp_at_pobox.com>
Date: 2005-09-17 13:57:37 CEST

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
> > I'm not sure when URLs are supposed to be canonicalised, but there was
> > definitely a bug or at least a code redundancy introduced by this
> > revision.
> >
...
> >
> > ... because here you're using "url" as input, and overwriting the
> > canonicalised "URL" with a new value without using it.
> >
> > So, is that canonicalisation still wanted?
>
> And may I add that having two variables named "URL" and "url" in the
> same function is just... well, let's say "bad" and leave it at that.
> Furthermore, the indentation of that entire curly-delimited block is
> wrong anyway.
>
> I have nobly resisted running 'svn blame' :-). I'm afraid of what I
> might find. Instead, I've fixed the indentation issue in r16149, and
> the URL/url issue, along with the canonicalization problem, in r16150.

Karl,

Thank you for cleaning up after my messy, messy self.

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 17 13:58:18 2005

This is an archived mail posted to the Subversion Dev mailing list.