Hi,
In <20050916134315.GC74254@home.clkao.org>
"swig changes for svn_txdelta_apply" on Fri, 16 Sep 2005 21:43:15 +0800,
Chia-liang Kao <clkao@clkao.org> wrote:
> I noticed your recent ruby binding improvements corrected the returned
> argument (md5) for svn_txdelta_apply. However this breaks existing
> perl bindings code using the API. The included test suite fails at
> t/5delta.t.
I noticed and pointed out that at
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=105063
> I am wondering if there's any way we can cope with the incompatibility
> more gracefully, as I actually want the fixed behaviour as well, but
> don't want to break existing code horribly.
I want Perl bindings to recover API in Perl side. I wanted
to do this by myself. I'm sorry but I can't understand
Perl...
I'll attach a patch that recover existing Perl bindings
svn_txdelta_apply API. If you don't agree with my approach,
could do you apply this patch?
Regards,
--
kou
Index: subversion/bindings/swig/include/svn_types.swg
===================================================================
--- subversion/bindings/swig/include/svn_types.swg ($B%j%S%8%g%s(B 16142)
+++ subversion/bindings/swig/include/svn_types.swg ($B:n6H%3%T!<(B)
@@ -499,8 +499,10 @@
svn_txdelta_apply() uses *result_digest not digest[] .
*/
%apply unsigned char digest[ANY] {
- unsigned char *digest,
- unsigned char *result_digest
+#ifdef SWIGRUBY
+ unsigned char *result_digest,
+#endif
+ unsigned char *digest
};
/* -----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 16 17:14:51 2005