[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Regression test for issue #2333

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-09-07 13:46:21 CEST

Malcolm Rowe wrote:
> Ping.
> Is anyone able to review this patch or the original analysis, or does the
> lack of any response mean that I've committed some dreadful faux pas?

Sorry for the lack of response. Thanks for paying attention to this issue, and
for the reminder. You're doing the right things, it's just that nobody in the
last few days has taken it upon themselves to review this. Like me, they may
have had your message marked for attention but not got around to it yet.

> Analysis: http://svn.haxx.se/dev/archive-2005-08/1343.shtml
> Patch (new regression test): http://svn.haxx.se/dev/archive-2005-08/1363.shtml
> [Yes, there's a missing parenthesis in the log message. If this is all
> that's wrong, I'll be very happy.]
> Summary for the impatient:
> svn diff produces the wrong output if a directory is renamed.
> To reproduce:
> $ svn log -r14414 -v http://svn.collab.net/repos/svn
> - shows /trunk/packages/rpm/wbel-3 being renamed to .../rhel-3.
> $ svn diff -r14413:14414 http://svn.collab.net/repos/svn | less
> - shows only the additions, not the deletions.
> Questions:
> 1. Is this a bug?


> 2. Are the regression tests correct?

Yes, I think so. And well written, thank you.

I've committed it as r16079.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 7 13:47:54 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.