[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ISSUE+PATCH: svn_load_dirs.pl fails on filenames containing $-sign ( probably Cygwin specific )

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2005-09-05 15:08:13 CEST

Citeren Lieven Govaerts <lgo@mobsol.be>:

> Citeren Max Bowsher <maxb@ukf.net>:
> > >>>
> > >>> Max,
> > >>>
> > >>> I don't have Perl installed in my windows environment, only as a cygwin
> > >>> package. As a double check, this is the info concerning perl and svn in
> > >>> my cygwin:
> > >>>
> > >>> $ which perl
> > >>> /usr/bin/perl
> > >>>
> > >>> $ perl --version
> > >>> This is perl, v5.8.7 built for cygwin-thread-multi-64int
> > >>>
> > >>> $ which svn
> > >>> /usr/bin/svn
> > >>>
> > >>> $ svn --version
> > >>> svn, version 1.2.0 (r14790)
> > >>> compiled Jun 10 2005, 22:10:10
> > >>>
> > >>> It's clear that the code in my patch is executed, as it fixes my
> > >>> problem.
> > >>> Any idea which other component can be involved then?
> > >>
> > >> The code you patched is definitely inside a conditional to run only for
> > >> native windows perl.
> >
> > Oops! I used the wrong quotes, so the shell ate $OSNAME itself.
> >
> > $ perl -MEnglish -e 'print $OSNAME;'
> >
> > Max.
> >
> $ perl -MEnglish -e 'print $OSNAME;'
> cygwin
> $
>
> Lieven.
>

It's already 7 years since I worked in Perl, so I'm not sure what is going on,
but I did a basic test making variable openfork_available local, and that gives
the expected results:

Line: 1415
# Start a child process safely without using /bin/sh.
sub safe_read_from_pipe
{
  my $openfork_available = "MSWin32" ne $OSNAME;

  unless (@_)
...

I checked in the Subversion repository and this issue seems to be solved in
trunk in revision 14782. I'm testing it now, but that probably solves
my problem. The version I used was from release 1.2.3.

Patch attached to first post in this thread may be ignored.

regards,

Lieven.

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 5 15:09:36 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.