[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Using post-commit hook for build checks [was: [patch] l10n crashes]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-09-03 12:03:37 CEST

Branko Čibej wrote:
> I thought the gettext tools could verify that the format strings in the
> translated messages are correct? If they can, we should do this checking
> in a post-commit hook.

That's an interesting idea, doing build checking in a post-commit hook*. You
mention it casually as if it's the normal thing to do, but I'm not aware that
we currently do any such thing.

Is our existing practice of relying on committers to do check their commit
(e.g. "make" and "make check" for core C code), and the automatic periodic
running of regression tests, not appropriate? If not, can we make use of this
post-commit idea for all sorts of tests, not just checking the format of
translations?

* If a not-trivial amount of checking is to be done then, instead of being done
within the hook, it can be done asynchronously, outside the hook, just being
triggered by the commit. And if it is triggered more than once by multiple
rapid commits before it has a chance to start, because the previous instance of
the test is still running, then it only needs to be run once more when the
current test finishes. This method would be the be the most efficient way to
run our existing periodic regression tests, instead of running them on a timer.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 3 12:04:26 2005

This is an archived mail posted to the Subversion Dev mailing list.