[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue 2394 no error dialog if lock command failed

From: Jani Averbach <jaa_at_jaa.iki.fi>
Date: 2005-09-02 02:11:26 CEST

On 2005-09-01 14:16+0200, Andriy Kulchytskyy wrote:
> Sorry for submitting invalid patch in previous message. This is my first
> time when I post a patch to an open source project.

Thanks for taking your time and doing it again Subversion's way.
 
> Find below a new patch, hope it is ok this time. I did check if it
> compiles. Though I did not do a regression test.
> We really need this bug fixed.

Here is the deal: I really don't like to commit this without
regression test and I know I won't have time until weekend.

So, there is a file:

subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests/BasicTests.java

which contains function testBasicLocking(). And there is a code
pattern (ensure existence of exception) how to test this at line 91 in
the same file.

If you don't have time to do the regression test, that's fine, I will
do it when I have time to commit.

BR, Jani

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 2 02:12:08 2005

This is an archived mail posted to the Subversion Dev mailing list.