Re: [PATCH]: notification progress improvement/fixes (issue #901)

Peter N. Lundblad wrote:
> Not all of our API users know our revving policy. I think it is a bit nice
> to be a little verbose here and give the reason. But if you change it, it
> should be changed everywhere.

API Users need not know about the revving policies in such detail. They
simply need to know that they have to go through the constructor.
Perhaps the implementation of the constructor could have a comment to
the effect of recalling the revving policy, but I'm not sure that
documenting it in the public API would bring anything but extra clutter.

> I suggest just allocating the struct by hand in wrapper_template.h (with a
> comment explaining why, of course). This is OK because you can't mix
> different libsvn_ra and libsvn_ra_whatever versions.

I see. Thanks for the explanation as to the purpose of
wrapper_template.h ! Once we've settled on the question of the
docstrings, I'll commit a fix for this.

>
> Thanks,
> //Peter
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 31 15:14:22 2005