Re: [PATCH]: notification progress improvement/fixes (issue #901)

Branko Čibej wrote:
> Don't even explain why. Just say, "Clients must use
> svn_ra_create_callbacks() to allocate and initialize this structure."

I was wondering about that, and decided to leave in minimal verbosity.
But it's true that it makes sense in the current revving policy for
structures, so no need to restate things.

> And let's please remove the unnecessary cast from void*. I don't care if
> VS.NET gripes about them at warning level 4 -- which is useless for
> normal code, anyway -- no-op casts clutter up the code for no benefit.

I was wondering about that too :-).

> Uh? Where does this dependency come from? I don't see either svnserve or
> libsvn_ra_svn using this constructor anywhere.

subversion/libsvn_ra_svn/client.c includes
subversion/libsvn_ra/wrapper_template.h, which refers to the constructor
in compat_open().

Any further comments before I submit a (final?) followup patch for this fix?
- Dave.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 31 03:57:21 2005