[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15993 - trunk/subversion/svnserve

From: <kfogel_at_collab.net>
Date: 2005-08-30 20:05:06 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> On Tue, 2005-08-30 at 11:08 -0500, kfogel@tigris.org wrote:
> > (must_have_access): Move pool to end of parameter list, as discussed
> > in review of r15982. All callers changed.
> I believe you just took a single function, which people happened to
> notice because it was touched in r15982, and made it inconsistent with
> the rest of serve.c. Didn't you notice you were doing that?

I made a quick check for consistency, but it just so happens that the
first few functions in serve.c put their pools at the end, so I
assumed it was must_have_access() which was inconsistent. Of course,
those first few function are not of the func(conn, pool, ...) variety,
that's why the pool doesn't come second for them!

Reverted in r16004, thanks for noticing.


www.collab.net  <>  CollabNet  |  Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 30 21:06:13 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.