[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15982 - in trunk: notes subversion/include subversion/libsvn_repos

From: David James <james82_at_gmail.com>
Date: 2005-08-30 14:16:08 CEST

> kfogel@collab.net wrote:
> > It's unusual to put POOL anywhere other than the end of the parameter
> > list; was there a reason? (Sorry, didn't notice last time around.)
In the SWIG bindings, we make the "pool" parameter optional. It's hard
to make a parameter optional if it's not the last parameter. So,
please stick to this convention (if you break it, the SWIG bindings
may have to be updated to explicitly ignore your new function).

On 8/30/05, David Anderson <david.anderson@calixo.net> wrote:
> Historical: must_have_write_access(), which this function evolved from,
> had the parameters in that order. At the time I was more concerned
> about how I was going to structure the code to accomodate both authz and
> blanket access control, and so forgot about it.
>
> But, it's an internal function, and can therefore be shoved around and
> reprototyped easily.
Great -- thanks!

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 30 14:17:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.