[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] check name svn special properties

From: <kfogel_at_collab.net>
Date: 2005-08-29 18:01:06 CEST

Fabien COELHO <fabien@coelho.net> writes:
> > Please find attached a patch which checks the name of svn special
> > properties and refuses unexpected ones. The check are performed in
> > the client library, where it seems to belong. The error can be
> > overridden with --force if necessary.
> >
> > The new feature is tested in the regression stuff. I had to remove 6
> > lines of some tests which were setting invalid svn special
> > properties, which are
> > now forbidden by default.
> May I gather after all the discussions that the submitted patch is
> rejected because of a lack of consensus? ;-)

I guess that's a fair summary, yeah. :-)

> Just my 0.02 euro-cents on the various views expressed in the discussion:
> I think that pre-commit is too late for a small stupid typo in an svn
> property name. Moreover it requires an additionnal setup for a feature
> that everybody should require, so that should be the default.
> I agree that having a nice "per-repository" client configuration would
> be a good idea and it would be the better place to put the constraint
> in to be exported to the client. But I don't see it coming, and I my
> typos are now;-)
> I think that the "hard coded" check I submitted could be removed once
> such a nicer dynamically configured checking is in place, so the very
> small patch I submitted could have been a temporary relief while
> waiting for the "grand" feature, some day... ;-)
> Thanks for having considered this patch anyway, have a nice day,

Thanks for submitting it.

I see the value in the feature, but just don't feel it's worth the
extra complexity needed to maintain it. That's why I didn't go
anywhere with the patch.


www.collab.net  <>  CollabNet  |  Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 29 19:02:36 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.