Re: [PATCH] Issue #1935: svn status too verbose with svn:externals definitions

I'm working late anyway, so I snuck in this quick update to my patch...

Scott

[[[
Fix issue #1935: svn status too verbose with svn:externals definitions

Unless the verbose option (-v) is specified, the message "Performing
status on external item at ..." is suppressed. When verbose and
quiet (-q) options are specified together the message will be printed
only when there will be relevant status output for that external folder.

* subversion/clients/cmdline/cl.h
   (svn_cl__status_baton): New. Replaces status_baton in status-cmd.c.
   (svn_cl__notify_baton): New. Replaces notify_baton in notify.c.
   The above structures were needed to communicate information about
the command line options to svn_wc_notify_status_external in notify.c
and to provide a place to remember information about the message that
will be accessible should the code in status-cmd.c determine that the
message is needed when verbose and quiet options are specified together.

While I generally didn't like to tie these two structures together or
duplicate the printing of the same message in two places, it appears
to be the simplest, most straightforward method to handle issue
#1935. Other possible implementations may require API changes that
should probably be considered outside the scope of this single issue.

* subversion/clients/cmdline/notify.c
     Modified processing of svn_wc_notify_status_external to
suppress output unless -v is specified (without -q). If the -q
option was specified then save enough information to regenerate the
message from status_cmd.c

* subversion/clients/cmdline/status-cmd.c
     If there is status to print and -q was specified with -v, print
the svn_wc_notify_status_external message from here, since this is
the point where we know that relevant status output for the external
folder will happen. There does not appear to be a straightforward
way to eliminate printing this message from two possible locations
(here and from notify.c)
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org